AIP-84: Migrating GET queued asset events for assets to FASTAPI #44139
+441
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
vatsrahul1001
added
the
legacy api
Co-authored-by: Pierre Jeambrun <[email protected]>
…nomer/airflow into AIP84-get-assets-queued-events-new
|
|
||
|
|
||
| @assets_router.get( | ||
| "/assets/queuedEvents/{uri:path}", |
There was a problem hiding this comment.
Suggested change
| "/assets/queuedEvents/{uri:path}", | |
| "/assets/queuedEvent/{uri:path}", |
This change will be done in a follow up PR on all queueEvent endpoints to keep consistency.
There was a problem hiding this comment.
@pierrejeambrun is there an issue for that I can pick that up?
vatsrahul1001
force-pushed
the
AIP84-get-assets-queued-events-new
branch
from
9523dbc
to
05c9f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #42370
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.