Ensure that the Task SDK regularly sends heartbeats for running tasks #44162
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
added
the
area:task-execution-interface-aip72
There is more nuance and edge cases to support, but this is the crux of the behaviour we want. This fixes the payload to be what the server expects, and fixes the URL suffix to match latest changes too
ashb
force-pushed
the
task-sdk-supervisor-heartbeat
branch
from
216680d
to
e016cb7
Compare
kaxil
approved these changes
Nov 18, 2024
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…apache#44162) There is more nuance and edge cases to support, but this is the crux of the behaviour we want. This fixes the payload to be what the server expects, and fixes the URL suffix to match latest changes too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more nuance and edge cases to support, but this is the crux of the
behaviour we want.
This fixes the payload to be what the server expects, and fixes the URL suffix
to match latest changes too
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.