-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grid View to new UI #45497
Add Grid View to new UI #45497
Conversation
11304dd
to
f0eb3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the glitches looks good!
Good call on the mapped task stuff. I made an issue for it here: #45990 Would you be able to make a gif or video of the second behavior you described? I am having a hard time understanding or I can't replicate it yet locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Beside the small issues mentioned by Jens.
Add task selection Refactor away from a table layout. Include pagination. Remove tooltips Add date ticks, remove multiple nested tasks iteration Add toggle groups, fix memos and date ticks Add title as standin for tooltips
Sorry for the delay, coming back post merge now. simplescreenrecorder-2025-01-25_21.48.58.mp4Attached please find the recording. Just tested post merge on current main. Clicks are not visual but whenever I click a task cell you see the runs are getting re-sorted by the length of the bars of DAG runs. |
* Basic grid view Add task selection Refactor away from a table layout. Include pagination. Remove tooltips Add date ticks, remove multiple nested tasks iteration Add toggle groups, fix memos and date ticks Add title as standin for tooltips * Fix comment * Rebase grid colors
Add an initial Grid View to the new UI.
Features:
Not included:
I think there's still too many magic numbers to make the layout work. Which I'm happy to work on as well as performance once we confirm that we want to use the grid view in this full page modal.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.