-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubernetes executor watcher kube_client_request_args shadowing #45528
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
4c73b7c
to
d62734a
Compare
d62734a
to
3177e52
Compare
I've checked failed tests in previous checks run And I can't find any reason for my changes to interfere with them. So I've rebased branch again |
providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to set the placeholder vars
…rnetes_executor_utils.py Apply suggestion by review Co-authored-by: Ryan Hatter <[email protected]>
Added as suggested. I am not familiar with code standards, so I was trying to minimize my "invasion". Thank you! |
Fix KubernetesJobWatcher shadowing kube client timeouts arguments
Provided change allows to have previously established defaults in KubernetesJobWatcher for client timeouts to not hang on events reading, but also do not overwrite them if they were provided in specific configuration option by user.
closes: #45517
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.