-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sphinx and related dependencies #45563
base: main
Are you sure you want to change the base?
Conversation
Drafting, weirdly on |
one more thing - last time when we tried to upgrade sphinx and docutils, the documentation looked ....weird .... lots of extra whitespace |
e65820a
to
e534e96
Compare
Apparently it is a quite a tough task, here are some insights:
I'll be happy for some help in solving some of the riddles above, it will gets us closer to upgrading to Sphinx 7 :) |
4ab3172
to
990cc6f
Compare
990cc6f
to
02a0446
Compare
#protm |
…html via Dockerfile.ci
@@ -1355,6 +1355,402 @@ ENV PATH="/files/bin/:/opt/airflow/scripts/in_container/bin/:${PATH}" \ | |||
# so we can go back to the default link mode being hardlink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be removed before merging
# By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle | ||
# <section> tags for sections | ||
"docutils<0.17,>=0.16", | ||
"docutils>=0.21", | ||
"sphinx-airflow-theme>=0.0.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, we should create a new version for sphinx-airflow-theme
(0.1.0) after merging apache/airflow-site#1103
closes: #31963
related: #39449
This PR update the following dependencies:
sphinx
to v7+ (there's already v8, but it is supported only for Python 3.10)docutils
to v0.21+ (haven't encountered any<section>
tags as mentioned in the deleted inline comment)sphinx-autoapi
to v3+ andastroid
to v3+ (possible now thatsphinx
is v7+)sphinxcontrib-serializinghtml
to v1.1.5+ (pinning it causes dependency conflicts)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.