-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove email configs, operator and callbacks #46041
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id: check-no-providers-in-core-examples
language: pygrep
name: No providers imports in core example DAGs
description: The core example DAGs have no dependencies other than standard provider or core Airflow
entry: "^\\s*from airflow\\.providers.(?!standard.)"
pass_filenames: true
files: ^airflow/example_dags/.*\.py$
What about pre-installed providers? if we really want to keep the rule as it is, then I will need to update the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do that. We should keep pre-installed to the minimum necessary.
Probably raise this as one of the items in the lazy consensus
037adbf
to
4e7df6e
Compare
We need also to remove the email and smtp part of airflow.cfg https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#smtp |
This PR:
email_on_retry
andemail_on_failure
to notify the users by email in favor of the SMTP notifierEmailOperator
fromairflow.operators.email
in favor ofairflow.providers.smtp.operators.smtp.EmailOperator
closes: #30530