Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email configs, operator and callbacks #46041

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hussein-awala
Copy link
Member

@hussein-awala hussein-awala commented Jan 25, 2025

This PR:

  • removes the ability to use email_on_retry and email_on_failure to notify the users by email in favor of the SMTP notifier
  • removes EmailOperator from airflow.operators.email in favor of airflow.providers.smtp.operators.smtp.EmailOperator
  • cleans their usage and remove SMTP section from Airflow configuration

closes: #30530

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

      - id: check-no-providers-in-core-examples
        language: pygrep
        name: No providers imports in core example DAGs
        description: The core example DAGs have no dependencies other than standard provider or core Airflow
        entry: "^\\s*from airflow\\.providers.(?!standard.)"
        pass_filenames: true
        files: ^airflow/example_dags/.*\.py$

What about pre-installed providers? if we really want to keep the rule as it is, then I will need to update the example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do that. We should keep pre-installed to the minimum necessary.
Probably raise this as one of the items in the lazy consensus

@eladkal
Copy link
Contributor

eladkal commented Jan 25, 2025

We need also to remove the email and smtp part of airflow.cfg
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#email

https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#smtp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate core EmailOperator to SMTP provider
2 participants