Skip to content

Conversation

aritra24
Copy link
Collaborator

Related: #46045

Provider Related PR: #41463
looks fairly stale, might not be relevant


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from code, lets have CI green...

@aritra24
Copy link
Collaborator Author

Looking into the failures... 🤔

@aritra24
Copy link
Collaborator Author

I guess it's due to the branch being out of date, merging main in to retry

@eladkal
Copy link
Contributor

eladkal commented Jan 29, 2025

tests are failing

@aritra24
Copy link
Collaborator Author

The failures do not seem related, @eladkal is there any place I can find out if these are flaky tests or have been failing off late?
I see errors like so, which don't seem related to this pr.

  airflow/api_connexion/endpoints/dag_run_endpoint.py:279: in get_dag_runs_batch
      readable_dag_ids = get_auth_manager().get_permitted_dag_ids(methods=["GET"], user=g.user)
  airflow/utils/session.py:101: in wrapper
      return func(*args, session=session, **kwargs)
  airflow/auth/managers/base_auth_manager.py:398: in get_permitted_dag_ids
      return self.filter_permitted_dag_ids(dag_ids=dag_ids, methods=methods, user=user)
  airflow/auth/managers/base_auth_manager.py:417: in filter_permitted_dag_ids
      if ("GET" in methods and self.is_authorized_dag(method="GET", user=user)) or (
  airflow/auth/managers/simple/simple_auth_manager.py:183: in is_authorized_dag
      return self._is_authorized(
  airflow/auth/managers/simple/simple_auth_manager.py:296: in _is_authorized
      user_role = user.get_role()
  E   AttributeError: 'NoneType' object has no attribute 'get_role'

@aritra24
Copy link
Collaborator Author

aritra24 commented Jan 29, 2025

@vincbeck it looks like your change in #45986 might have broken the amazon provider test in 2.9.3 compat? I see the same error on your pr but somehow the ci passed? Could you take a look? fixed in #46245

@potiuk potiuk merged commit 162f435 into apache:main Jan 30, 2025
92 checks passed
dabla pushed a commit to dabla/airflow that referenced this pull request Jan 30, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
@aritra24 aritra24 deleted the move_ftp branch May 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants