AIP-38: remove default_ui_timezone
#49176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
requested review from
vincbeck,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
ephraimbuddy and
rawwar
as code owners
boring-cyborg
bot
added
area:API
guan404ming
force-pushed
the
remove-default_ui_timezone
branch
2 times, most recently
from
8498138 to
699fd13
Compare
There was a problem hiding this comment.
We could drop that, but I find it to be an interesting small feature at a limited cost. (For now the complexity added is low, maintainability is close to None too because everything is handled by the TimezoneProvider and we rarely update that piece of code) I'm not sure if we should drop it.
What do you think @bbovenzi ?
|
I'm ambivalent. Generally I like to simplify config, and I like to have less of the UI dictated by the config and 3.0 is the time to remove old ones. |
kaxil
approved these changes
Apr 14, 2025
|
Ok let’s go for removal then |
pierrejeambrun
approved these changes
Apr 15, 2025
|
Thanks for reviewing~ |
guan404ming
force-pushed
the
remove-default_ui_timezone
branch
from
699fd13 to
3ff810d
Compare
guan404ming
force-pushed
the
remove-default_ui_timezone
branch
from
3ff810d to
5ee2bce
Compare
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Why
The
default_ui_timezoneconfiguration was adding unnecessary complexity to the Airflow UI timezone management. By removing this configuration and always using the system timezone as default, it would have better user experience.How
default_ui_timezonefrom configuration files^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.