Skip to content

Fix some mistakes in AirbyteJobSensor docs. #49196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025

Conversation

tuliolima
Copy link
Contributor

@tuliolima tuliolima commented Apr 13, 2025

It moves a line of airbyte_conn_id description which were in the wrong place and adds more information to deferrable param.

Copy link

boring-cyborg bot commented Apr 13, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@tuliolima tuliolima changed the title fix(airbyte): fixing some mistakes in AirbyteJobSensor docs. Fix some mistakes in AirbyteJobSensor docs. Apr 13, 2025
@tuliolima tuliolima marked this pull request as ready for review April 13, 2025 22:02
@potiuk potiuk merged commit c487448 into apache:main Apr 14, 2025
61 of 88 checks passed
Copy link

boring-cyborg bot commented Apr 14, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@tuliolima tuliolima deleted the fix/airbyte_docs branch April 14, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants