Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Apr 20, 2025

Related Issue

#48104

Why

  • do have sort function but do not have default sort
  • checkbox is hardly to be seen

How

  • add default sorting into default table state
  • borden the width of the checkbox
  • minor change: remove TODO: Implement the export selected since it seems like it's already been done.

before

image
image

after

image
image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 20, 2025
@guan404ming guan404ming changed the title AIP-38: set default sort by key and borden the border width in Variables AIP-38: set default sort by key and borden borderWidth in Variables Apr 20, 2025
@guan404ming guan404ming changed the title AIP-38: set default sort by key and borden borderWidth in Variables AIP-38: sort by key as default and borden borderWidth in Variables Apr 20, 2025
@guan404ming guan404ming changed the title AIP-38: sort by key as default and borden borderWidth in Variables AIP-38: sort by key as default and borden checkbox borderWidth in Variables Apr 20, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good!

@jscheffl jscheffl merged commit 14d4a8d into apache:main Apr 20, 2025
43 checks passed
@guan404ming guan404ming deleted the default-sort-by-key branch April 20, 2025 18:23
@jscheffl jscheffl added this to the Airflow 3.1.0 milestone Apr 20, 2025
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants