[1/4] Transition of get-value config command

[yunchipang]

partially closes: #45664
parent issue: #45661

implements get-value config command. unit tests are added.

[yunchipang]

@bugraoz93 I think I’m starting to get a good grasp of how the transitioning works. However, I’m currently hitting this error:

root@a93cfff4a88c:/opt/airflow# airflowctl config get-value --section core --option dags_folder
Usage: airflowctl config [-h] COMMAND ...

Perform Config operations

Positional Arguments:
  COMMAND
    get       Perform get operation

Optional Arguments:
  -h, --help  show this help message and exit

airflowctl config command error: argument COMMAND: invalid choice: 'get-value' (choose from 'get'), see help above.

It seems like my get-value config ActionCommand isn’t being successfully registered in cli_config.py, and I haven’t been able to figure out why. Could you take a quick look and see if there’s something I might’ve missed?

Note: This PR is still in draft—only get_value has been migrated so far. I’ll complete the rest once I get past this blocker 😆

Thanks a lot!

[bugraoz93]

Thanks for the PR!

Basic commands are already generated automatically via 1-1 operation-command mapping.
Operations
https://github.com/apache/airflow/blob/main/airflow-ctl/src/airflowctl/api/operations.py
Auto Generation

airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py

Line 212 in 879b681

class CommandFactory:

If you run airflowctl --help or more specifically airflowctl config --help. For example, in this case, all methods you added should stay and get-value shouldn't be there because get comes from the generated part.

@bugraoz93 I think I’m starting to get a good grasp of how the transitioning works. However, I’m currently hitting this error:

airflowctl config command error: argument COMMAND: invalid choice: 'get-value' (choose from 'get'), see help above.
It seems like my get-value config ActionCommand isn’t being successfully registered in cli_config.py, and I haven’t been able to figure out why. Could you take a quick look and see if there’s something I might’ve missed?

I think one overrides the other since both GroupCommand have the same name. This gives precedence to one.
I have created a PR for this. When it is merged, you will be safely included commands and test it.
#49674

[yunchipang]

@bugraoz93 I wanted to limit this PR to only transitions the get-value config command, as this might get too large and hard to review if all 4 commands (get-value, list, lint, update) are implemented. Unit tests are added, please take a look and let me know your thoughts.

I have one concern here, in the old airflow CLI, get is not displayed as a command (see below).

However, with the new auto-gen of commands, get will be listed as one of the available commands when I use airflowctl config -h. I am not sure is this is intended, or we should find a way to undo that.

note: trying to fix CI error!

[bugraoz93]

@bugraoz93 I wanted to limit this PR to only transitions the get-value config command, as this might get too large and hard to review if all 4 commands (get-value, list, lint, update) are implemented. Unit tests are added, please take a look and let me know your thoughts.

I have one concern here, in the old airflow CLI, get is not displayed as a command (see below).

However, with the new auto-gen of commands, get will be listed as one of the available commands when I use airflowctl config -h. I am not sure is this is intended, or we should find a way to undo that.

note: trying to fix CI error!

Hey @yunchipang, it is okay to do it step by step and command by com and. For get-value, as I mentioned in my previous comment.

Basic commands are already generated automatically via 1-1 operation-command mapping.
Operations
https://github.com/apache/airflow/blob/main/airflow-ctl/src/airflowctl/api/operations.py
Auto Generation

airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py

Line 212 in 879b681

class CommandFactory:

If you run airflowctl --help or more specifically airflowctl config --help. For example, in this case, all methods you added should stay and get-value shouldn't be there because get comes from the generated part.

This is expected, and we shouldn't implement anything that comes from generated commands from operations. This is not a problem but intended behavior. They will serve to the same purpose and do the same thing. So please skip get-value. Only focus on the capability other than generated ones.