Skip to content

Add PoolSummary in dashboard #49794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

Add PoolSummary in dashboard #49794

merged 3 commits into from
Apr 29, 2025

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Apr 25, 2025

Related Issue

closes #43328

Why

  • currently no PoolSummary in dashboard

How

  • move slots to utils
  • implement one in dashboard look like this

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 25, 2025
@potiuk potiuk force-pushed the add-pool-summary branch from 2a129bf to c97f0e8 Compare April 26, 2025 13:15
pierrejeambrun
pierrejeambrun reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, a few comments

@guan404ming guan404ming force-pushed the add-pool-summary branch 2 times, most recently from da245ed to 3925e43 Compare April 28, 2025 14:22
pierrejeambrun
pierrejeambrun reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better thanks. We need to solve conflicts and do a better typing to be able to remove some hard casting and we should be good to go.

@guan404ming guan404ming force-pushed the add-pool-summary branch 2 times, most recently from 8557eb6 to bd86ef7 Compare April 28, 2025 15:29
@guan404ming
Copy link
Member Author

guan404ming commented Apr 28, 2025

I change the slotConfigs into array and it did help to make the type annotation much more better.

Since I always got the string type even when I passing the Literal type like "open" | "occuppied" to Object.entries, it seems like it blames to ts. Thus, I need to perform lots of tricks to make type checker be happy. But change it into array solve this. Thanks to array.

pierrejeambrun
pierrejeambrun reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, just a few comments

bbovenzi
bbovenzi reviewed Apr 28, 2025
View reviewed changes
@guan404ming
Copy link
Member Author

guan404ming commented Apr 28, 2025

Current UI with link
image

bbovenzi
bbovenzi approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

guan404ming and others added 3 commits April 29, 2025 10:28
pierrejeambrun
pierrejeambrun approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.0 milestone Apr 29, 2025
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 29, 2025

Marked for 3.1

@pierrejeambrun pierrejeambrun merged commit 3a3b1b8 into apache:main Apr 29, 2025
42 checks passed
@guan404ming guan404ming deleted the add-pool-summary branch April 29, 2025 11:02
@guan404ming
Copy link
Member Author

guan404ming commented Apr 29, 2025

Thanks for the review!

mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@guan404ming @pierrejeambrun
@bbovenzi @mvfc
feat: add PoolSummary in dashboard (apache#49794)
15b4102 
* feat: add `PoolSummary` in dashboard

Co-authored-by: pierrejeambrun <[email protected]>

* type: refine slots type annotation

* fix: update `PoolSummary`

Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>

---------

Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@guan404ming @pierrejeambrun
@bbovenzi @mvfc
feat: add PoolSummary in dashboard (apache#49794)
fed8526 
* feat: add `PoolSummary` in dashboard

Co-authored-by: pierrejeambrun <[email protected]>

* type: refine slots type annotation

* fix: update `PoolSummary`

Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>

---------

Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@guan404ming @pierrejeambrun
@bbovenzi @mvfc
feat: add PoolSummary in dashboard (apache#49794)
6d82387 
* feat: add `PoolSummary` in dashboard

Co-authored-by: pierrejeambrun <[email protected]>

* type: refine slots type annotation

* fix: update `PoolSummary`

Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>

---------

Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
@guan404ming @pierrejeambrun
@bbovenzi @jroachgolf84
feat: add PoolSummary in dashboard (apache#49794)
6a77328 
* feat: add `PoolSummary` in dashboard

Co-authored-by: pierrejeambrun <[email protected]>

* type: refine slots type annotation

* fix: update `PoolSummary`

Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>

---------

Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
@guan404ming guan404ming changed the title feat: add PoolSummary in dashboard Add PoolSummary in dashboard Apr 30, 2025
@kaxil kaxil mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

AIP-38 | Add Pool Summary stats to Dashboard

3 participants

@guan404ming @pierrejeambrun @bbovenzi