Skip to content

Conversation

@guan404ming
Copy link
Member

Related Issue

#46730

How

  • alias the dag_display_name for BackfillResponse

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@guan404ming
Copy link
Member Author

Fixing test currently.

@pierrejeambrun pierrejeambrun marked this pull request as draft April 30, 2025 11:07
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 30, 2025

I just converted to draft, so we don't get notified on each commits / updates until this is ready. Feel free to convert back to ready for review when you fixed those, thanks.

@guan404ming guan404ming force-pushed the alias-backfillResponse branch from 3ae76bf to dfae172 Compare April 30, 2025 11:09
@guan404ming
Copy link
Member Author

Sorry for bothering. I would turn it back to ready for review after the ci become green. Thanks.

@guan404ming guan404ming force-pushed the alias-backfillResponse branch from dfae172 to 0dd2bac Compare April 30, 2025 11:13
@guan404ming guan404ming changed the title AIP-84: alias dag_display_name for BackfillResponse AIP-84: alias dag_display_name for BackfillResponse Apr 30, 2025
@guan404ming guan404ming force-pushed the alias-backfillResponse branch from 0dd2bac to 73e34ed Compare April 30, 2025 12:15
@guan404ming guan404ming marked this pull request as ready for review April 30, 2025 13:04
@guan404ming
Copy link
Member Author

It seems like the CI error is not relevant to my changes.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, you'll need to rebase for the CI to be green. (recently we can't force merge red CI even if failure are unrelated)

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.0 milestone Apr 30, 2025
@guan404ming guan404ming force-pushed the alias-backfillResponse branch from 73e34ed to ee64f17 Compare April 30, 2025 13:58
@guan404ming
Copy link
Member Author

Sure, thanks for your review. I have rebased~

@guan404ming guan404ming force-pushed the alias-backfillResponse branch from ee64f17 to c39f756 Compare April 30, 2025 15:33
@bbovenzi bbovenzi merged commit 6d76410 into apache:main Apr 30, 2025
97 checks passed
@guan404ming guan404ming deleted the alias-backfillResponse branch April 30, 2025 19:28
@guan404ming
Copy link
Member Author

Thanks for the review~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants