Added last_asset_event_id and last_asset_event_timestamp to the AssetResponse
#50060
+169
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:API
|
@pierrejeambrun, @bbovenzi, #49994 closed in favor of this PR. |
jroachgolf84
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
shubhamraj-git,
bugraoz93,
kaxil,
potiuk,
ephraimbuddy,
rawwar and
jason810496
as code owners
bbovenzi
reviewed
May 1, 2025
Comment on lines
142
to
147
| AssetEvent.asset_id, # The ID of the Asset, which we'll need to JOIN to the AssetModel | ||
| func.max(AssetEvent.id).label("last_asset_event_id"), # The ID of the last AssetEvent | ||
| func.max(AssetEvent.timestamp).label("last_asset_event_timestamp"), | ||
| ) | ||
| .group_by(AssetEvent.asset_id) | ||
| .subquery() |
There was a problem hiding this comment.
Let's make sure we're actually selecting the latest timestamp here
There was a problem hiding this comment.
Can you clarify that a bit more? Is the thought here that the max AssetEvent.id might not have the latest timestamp?
There is a unit-test validating this - would you just approach this with a self-JOIN?
…f max(AssetEvent.id) has the max(AssetEvent.timestamp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
last_asset_event_idandlast_asset_event_timestampfields to theAssetResponsemodel, and thus, the/assetsendpoint. The original use-case was to make the Asset list view sortable by the last Asset Event. However, there is a much larger use-case at play here; the ability to easily determine the timestamp for the last Asset Event for a certain Asset. This is especially applicable for Asset Watchers.By default, the
last_asset_event_idandlast_asset_event_timestampfields are returned asnull. It's not until the first Asset Event that these fields are populated.Unit-tests were added/updated for all changes made.
related: #47164