Add breeze to the main workspace of the apache-airflow-project #50078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With apache#50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The apache#50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run.
gopidesupavan
approved these changes
May 1, 2025
|
No. It's just development workspace. |
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2025
…oject (#50078) With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The #50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run. (cherry picked from commit e6d6cc1) Co-authored-by: Jarek Potiuk <[email protected]>
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
May 1, 2025
…oject (#50078) (#50080) With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The #50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run. (cherry picked from commit e6d6cc1) Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same
.venvenvironment and when someone wants to runbreezetests using that.venv, it is great ifuv syncinstalls all that is needed to run breeze tests as well. The #50059 addedawswranglerthat was not part of any other project and even afteruv syncin the main repo,breezetests could not be run.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.