Add task group detail for dag run selected case#50309
Merged
bbovenzi merged 5 commits intoapache:mainfrom May 8, 2025
Merged
Conversation
205ab09 to
07d6a6d
Compare
bbovenzi
reviewed
May 7, 2025
Contributor
bbovenzi
left a comment
There was a problem hiding this comment.
Great work taking this on!
Also, please check out the isSelected logic we have on the grid bar and task name to make sure the "crosshair" selection still works for Task Groups
airflow-core/src/airflow/ui/src/pages/GroupTaskInstance/Header.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/GroupTaskInstance/Header.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/GroupTaskInstance/GroupTaskInstance.tsx
Outdated
Show resolved
Hide resolved
Member
Author
bbfcc29 to
33d6fa8
Compare
Contributor
Contributor
|
In another PR, we should create a Task Group across dag runs page too just like our Task across Runs page. |
Member
Author
|
Sorry I missed it and I've added it. Thanks for pointing out.
I plan to implement it as a following PR. |
bbovenzi
approved these changes
May 8, 2025
Member
Author
|
Thanks! I would implement next one at the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Issue
#49741
Why
Currently we do have mapped task detail page but we don't have the group one.
How
Note
Task group is a little bit more tricky than mapped one. Since tasks in group don't have same
task_idlike mapped ones, its task_id follow the format like{parent_task_id}.{task_id}, which means we couldn't fetch them barely using thetask_id. Thus, I use groupId in route to determine whether it is group task and I use taskNamePattern to fetch all child for it. Not sure if it's the best way to implement it so I decide to split into maybe 2-3 PRs make sure I keep on the right track and gather feedback at each stage. Please let me know if you have any suggestions or concerns about the approach. Thanks in advance!test case: simple group
Screen.Recording.2025-05-08.at.12.27.12.AM.mov
test case: nested group
Screen.Recording.2025-05-08.at.12.32.12.AM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.