Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented May 7, 2025

Related Issue

#49741

Why

Currently we do have mapped task detail page but we don't have the group one.

How

  • implement for dag run selected case for now

Note

Task group is a little bit more tricky than mapped one. Since tasks in group don't have same task_id like mapped ones, its task_id follow the format like {parent_task_id}.{task_id}, which means we couldn't fetch them barely using the task_id. Thus, I use groupId in route to determine whether it is group task and I use taskNamePattern to fetch all child for it. Not sure if it's the best way to implement it so I decide to split into maybe 2-3 PRs make sure I keep on the right track and gather feedback at each stage. Please let me know if you have any suggestions or concerns about the approach. Thanks in advance!

test case: simple group

Screen.Recording.2025-05-08.at.12.27.12.AM.mov

test case: nested group

Screen.Recording.2025-05-08.at.12.32.12.AM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 7, 2025
@guan404ming guan404ming force-pushed the add-group-summary branch 2 times, most recently from 205ab09 to 07d6a6d Compare May 7, 2025 16:35
@guan404ming guan404ming marked this pull request as ready for review May 7, 2025 16:43
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work taking this on!

Also, please check out the isSelected logic we have on the grid bar and task name to make sure the "crosshair" selection still works for Task Groups

@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone May 7, 2025
@guan404ming
Copy link
Member Author

Fixed~
image

@guan404ming guan404ming force-pushed the add-group-summary branch from bbfcc29 to 33d6fa8 Compare May 7, 2025 22:43
@bbovenzi
Copy link
Contributor

bbovenzi commented May 8, 2025

TaskName is getting the appropriate background but GridTIs do not. In GridTI.tsx, we need to also pull down the groupId from useParams() and use it in the comparisonat `bg={selectedTaskId === taskId ? "blue.muted" : undefined}``

Screenshot 2025-05-08 at 10 16 14 AM

@bbovenzi
Copy link
Contributor

bbovenzi commented May 8, 2025

In another PR, we should create a Task Group across dag runs page too just like our Task across Runs page.

@guan404ming
Copy link
Member Author

guan404ming commented May 8, 2025

Sorry I missed it and I've added it. Thanks for pointing out.

In another PR, we should create a Task Group across dag runs page too just like our Task across Runs page.

I plan to implement it as a following PR.

@bbovenzi bbovenzi merged commit c7afcfc into apache:main May 8, 2025
42 checks passed
@guan404ming guan404ming deleted the add-group-summary branch May 8, 2025 15:55
@guan404ming
Copy link
Member Author

Thanks! I would implement next one at the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants