Avoid importing from sdk when deprecating using utils #50435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
May 10, 2025
hussein-awala
approved these changes
May 11, 2025
kaxil
reviewed
May 12, 2025
Co-authored-by: Kaxil Naik <[email protected]>
kaxil
approved these changes
May 12, 2025
potiuk
approved these changes
May 12, 2025
jedcunningham
approved these changes
May 12, 2025
Member
|
Feels like this might be better for 3.1 instead of 3.0.2? |
amoghrajesh
added
the
backport-to-v3-1-test
Contributor
Author
|
@kaxil can we merge this? Should it be 3.0.2 or 3.1? I added backport labels |
kaxil
removed
the
backport-to-v3-1-test
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to import it this way when we are anyways deprecating it using
add_deprecated_classes^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.