Fix unreachable code errors in Vault provider #53437
Open
+6
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:secrets
provider:hashicorp
| connections_path: str = "connections", | ||
| variables_path: str = "variables", | ||
| config_path: str = "config", | ||
| connections_path: str | None = "connections", |
There was a problem hiding this comment.
does connection paths are optional i think atleast these are mandatory to work ?
cc: @amoghrajesh adding as you mostly worked related to connection any thoughts ?
There was a problem hiding this comment.
I assumed they are nullable as in line 50 it says (default: 'connections'). If set to None (null), requests for connections will not be sent to Vault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #53395