Add stream method to RemoteIO #54813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:alibaba
provider:amazon
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
88b1454 to
a7c7322
Compare
ashb
reviewed
Aug 27, 2025
providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py
Outdated
Show resolved
Hide resolved
ashb
added
the
full tests needed
Member
|
re-triggering tests |
ashb
reviewed
Sep 4, 2025
ashb
reviewed
Sep 4, 2025
providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/log/cloudwatch_task_handler.py
Outdated
Show resolved
Hide resolved
jason810496
added
the
backport-to-v3-1-test
Member
Author
|
I added |
kaxil
removed
the
backport-to-v3-1-test
ashb
reviewed
Sep 16, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
You seem to have added some test classes that have no test functions, so the fixtures will never be run?
providers/apache/hdfs/tests/unit/apache/hdfs/log/test_hdfs_task_handler.py
Outdated
Show resolved
Hide resolved
providers/alibaba/tests/unit/alibaba/cloud/log/test_oss_task_handler.py
Outdated
Show resolved
Hide resolved
providers/google/tests/unit/google/cloud/log/test_gcs_task_handler.py
Outdated
Show resolved
Hide resolved
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
8125772 to
fd7d0b5
Compare
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
fd7d0b5 to
3be54d3
Compare
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
3be54d3 to
353e66e
Compare
jason810496
commented
Oct 22, 2025
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
32b47a1 to
2372ad8
Compare
potiuk
force-pushed
the
refactor/logging/add-stream-method
branch
from
2372ad8 to
8304975
Compare
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
2 times, most recently
from
2d64952 to
9afa883
Compare
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
9afa883 to
c56da4d
Compare
Lee-W
approved these changes
Nov 3, 2025
jason810496
force-pushed
the
refactor/logging/add-stream-method
branch
from
c56da4d to
00fcf78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: Fix CloudwatchTaskHandler display error #54054
Why
While fixing comments in #54054, I realized that we should support
streammethod inRemoteIOas #54054 (review) point out. Starting with Airflow 3, FileTaskHandler._read_remote_logs will utilizeRemoteIObehind the scenes, rather than relying on<Provider>TaskHandler._read_remote_logs.What
Add
streammethod toRemoteIOProtocol and add corresponding unit tests.