[v3-1-test] Fix retry callbacks not executing for externally killed tasks (#56586) #56607
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
…asks (#56586) * Fix retry callbacks not executing for externally killed tasks When tasks with remaining retries were killed externally the `on_failure_callback` was incorrectly executed instead of `on_retry_callback`. The scheduler now correctly sets the callback type to `UP_FOR_RETRY` when tasks are eligible to retry, ensuring proper callback and email routing. For heartbeat timeouts, the task is loaded before evaluating retry eligibility to access the task's retry configuration. Fixes #56196 * fixup! Fix retry callbacks not executing for externally killed tasks (cherry picked from commit 04d3c44) Co-authored-by: Kaxil Naik <[email protected]>
boring-cyborg
bot
added
the
area:Scheduler
kaxil
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tasks with remaining retries were killed externally the
on_failure_callbackwas incorrectly executedinstead of
on_retry_callback.The scheduler now correctly sets the callback type to
UP_FOR_RETRYwhentasks are eligible to retry, ensuring proper callback and email routing.
For heartbeat timeouts, the task is loaded before evaluating retry
eligibility to access the task's retry configuration.
Fixes #56196
(cherry picked from commit 04d3c44)
Co-authored-by: Kaxil Naik [email protected]