-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Docs: clarify BaseSensorOperator params #60203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs: clarify BaseSensorOperator params #60203
Conversation
|
@uranusjr @phanikumv Thanks for the reviews! I've addressed the feedback:
The changes now cleanly add: This should resolve the issue where BaseSensorOperator wasn't clickable in provider documentation, making sensor parameters easier to discover. Thanks again for the feedback! |
|
Can you please show docs generated by it with clickable classes ? (screenshot) |
c6a5ef0 to
eeae301
Compare
|
I also rebased it and added "full tests needed" just in case. |
|
Some mypy issue to fix @Ajay9704 |
|
@potiuk Sir , sorry for troubling you , but unfortunately my changes didn't worked for static checks , |
I have approved the workflows to run now |
|
@phanikumv ,Thanks for your patience. I realized that i had missed placing an import at the top of the file earlier, which caused the static check failure. I’ve fixed the import order now and cleaned up the code accordingly. Could you please re-run the checks when you get a chance? Thanks a lot for your review and guidance. |
done, triggered the re-run |
|
Hi @potiuk Sir, @potiuk , @phanikumv thank you very much for your patience and for helping by re-triggering the checks so far |
hard to say - but this is part of the task to figure out how to make the build succeed, I suggest you try to run it locally - following contributing guide, build it for one provider, look at the errors and try to fix it. |
5439427 to
41143dd
Compare
Summary
This PR resolves issue #60185 where BaseSensorOperator wasn't clickable in provider documentation, making it hard to find information about sensor parameters.
The Problem
I discovered that BaseSensorOperator lives in the new Task SDK at airflow/task-sdk/src/airflow/sdk/bases/sensor.py, but when building documentation for providers, the system only scanned the current provider's source code. This meant that when providers like the standard sensors referenced BaseSensorOperator, the documentation couldn't create proper links to the actual class definition.
My Approach
I modified airflow/devel-common/src/docs/provider_conf.py to:
Impact
This change means users can now click on BaseSensorOperator references in provider documentation and jump directly to the class definition to see all available parameters and methods. Much more user-friendly