-
Notifications
You must be signed in to change notification settings - Fork 353
[AMORO-3697] add Flink 1.18 support for mixed-format #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...moro-mixed-flink-common/src/main/java/org/apache/amoro/flink/read/internals/KafkaSource.java
Show resolved
Hide resolved
amoro-format-mixed/amoro-mixed-flink/v1.18/amoro-mixed-flink-runtime-1.18/pom.xml
Show resolved
Hide resolved
Hi, you may need to change the access modifier of |
Thanks for the review!
I have aligned it with Iceberg 1.6.1, and above UTs passed locally. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3700 +/- ##
============================================
- Coverage 28.53% 28.48% -0.06%
+ Complexity 3759 3756 -3
============================================
Files 617 617
Lines 50056 49976 -80
Branches 6482 6440 -42
============================================
- Hits 14283 14234 -49
+ Misses 34760 34729 -31
Partials 1013 1013
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...-flink-common/src/main/java/org/apache/amoro/flink/read/hybrid/split/TemporalJoinSplits.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the contribution!
Why are the changes needed?
Close #3697
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation