Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lrucache to cache expression result for chaitin-waf plugin #11705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sreeram-venkitesh
Copy link

Description

Fixes part of #9945

#9945 includes 3 tasks. One of them is caching the expression result in the plugin code. This PR attempts to fix this part of the issue. I would love to get feedback to understand if I'm on the right path here.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. plugin labels Nov 1, 2024
@membphis
Copy link
Member

@sreeram-venkitesh thx for your PR first, and pls take some time to update the PR's title

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants