-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: ensure UI directory is created when building debian-dev image #12754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sihyeon Jang <[email protected]>
|
Hi @sihyeonn, you can merge the latest main branch to make CI pass. |
Thank you for your review! But I still need 2 more reviews to merge 🥲 Merging is blocked! |
|
The failed test appears to be unrelated to this change and has already been fixed in the main branch. |
SkyeYoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 What you're doing is feasible, but currently, the debian-dev build is used like this: https://github.com/apache/apisix/blob/master/.github/workflows/push-dev-image-on-commit.yml#L37-L54
So I think, you might as well move the part of building the UI directly into the Makefile.
Or is your idea that you don’t want a UI?
|
Hi @SkyeYoung, thanks for the review! Yes, this is for use cases where the UI is not needed. I use Moving the UI build from the workflow into the Makefile as you suggested is one approach, but it would increase build time and complexity for development environments where the UI isn't necessary. The current fix just creates an empty directory to allow builds to succeed without UI assets - it's a minimal change. Do you think there's a better approach to handle this? |
|
Hi @sihyeonn, thank you for your contribution, but we are unsure if this requirement aligns with the needs of most users, so we need more discussion on this topic within the community. |
Description
This PR fixes a build failure when running
make build-on-debian-dev.The debian-dev image build failed at:
[2/2] STEP 9/21: COPY --chown=nobody:root ui/ /usr/local/apisix/ui/
Error: building at STEP "COPY --chown=nobody:root ui/ /usr/local/apisix/ui/": checking on sources under "/var/tmp/libpod_builder971763380/build": copier: stat: "/ui": no such file or directorybecause the
uidirectory does not exist in the build context.To resolve this, the build script now ensures that an (empty)
uidirectory is created before building the debian-dev image, so theCOPY ui/ /usr/local/apisix/ui/step always succeeds even when no UI assets are present.Which issue(s) this PR fixes:
Fixes #
Checklist