Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARIES-2161] Update destroy method to be compatible with spring 5 and 6 #299

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

f2par0
Copy link
Contributor

@f2par0 f2par0 commented Dec 2, 2024

Problem found : the class SpringApplicationContext inherits from org.springframework.context.support.AbstractApplicationContext , which had a destroy method in version 4, but was deprecated then removed in the version 6 of spring framework.

The name of the destroy method must be updated to match this new name

@alien11689
Copy link
Contributor

Hi @f2par0
could you create an jira issue and add jira id to the PR name and commit?
The blueprint-spring subproject has a dependency to spring - could you also check them? I think they should be updated to version 6.x

@f2par0 f2par0 changed the title update destroy method to be compatible with spring 6 [ARIES-2161] update destroy method to be compatible with spring 6 Dec 2, 2024
blueprint/blueprint-spring/pom.xml Outdated Show resolved Hide resolved
blueprint/blueprint-spring/pom.xml Outdated Show resolved Hide resolved
@amergey
Copy link

amergey commented Jan 5, 2025

You may have a look to an old PR I opened for spring 5 which should work for spring 6 as well
https://github.com/apache/aries/pull/300/files

@alien11689 alien11689 changed the title [ARIES-2161] update destroy method to be compatible with spring 6 [ARIES-2161] Update destroy method to be compatible with spring 5 and 6 Jan 17, 2025
@jbonofre jbonofre self-requested a review January 27, 2025 12:53
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Not sure if the spring-extender is heavily used thought :)

@alien11689 alien11689 merged commit cf98954 into apache:trunk Jan 27, 2025
1 check passed
@alien11689
Copy link
Contributor

Thank you @f2par0 for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants