-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update self-hosted arm runner to ubuntu-24.04-arm #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I would remove the if check for the GitHub repository owner and run on arm as we do for amd64. I mean removing:
if [ "$GITHUB_REPOSITORY_OWNER" = "apache" ]; then
echo "," >> "$GITHUB_OUTPUT"
cat <<JSON >> "$GITHUB_OUTPUT"
and reorganize the code to a single JSON write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you remove the |
If you want an example from what @kou suggests you can see this diff on the main apache/arrow repo where the |
Done. Let's trigger the runner for testing. |
Signed-off-by: Saurabh Kumar Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!
@singh1203 @kou @raulcd It looks like the ARM jobs are still failing unable to find a runner :( any ideas? |
After rebase, #266 is good to go, but in #264 couple of runners are failing. |
Fixes: #267
What changes are included in this PR?
Replaced the running platform from
self-hosted arm
runner toubuntu-24.04-arm
Are these changes tested?
Not locally, but can be tested by triggering the runner
Are there any user-facing changes?
No