-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update self-hosted arm runner to ubuntu-24.04-arm #268
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I would remove the if check for the GitHub repository owner and run on arm as we do for amd64. I mean removing:
if [ "$GITHUB_REPOSITORY_OWNER" = "apache" ]; then
echo "," >> "$GITHUB_OUTPUT"
cat <<JSON >> "$GITHUB_OUTPUT"
and reorganize the code to a single JSON write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you remove the |
If you want an example from what @kou suggests you can see this diff on the main apache/arrow repo where the |
Signed-off-by: Saurabh Kumar Singh <[email protected]>
Done. Let's trigger the runner for testing. |
- arch: amd64 | ||
go: 1.22 | ||
runs-on: ubuntu-latest | ||
arch-label: AMD64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep these keys in alphabetical order?
- arch: amd64 | |
go: 1.22 | |
runs-on: ubuntu-latest | |
arch-label: AMD64 | |
- arch-label: AMD64 | |
arch: amd64 | |
go: 1.22 | |
runs-on: ubuntu-latest |
Fixes: #267
What changes are included in this PR?
Replaced the running platform from
self-hosted arm
runner toubuntu-24.04-arm
Are these changes tested?
Not locally, but can be tested by triggering the runner
Are there any user-facing changes?
No