Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-107: Add test CI for arm Runners #123

Merged
merged 1 commit into from
Sep 13, 2024
Merged

GH-107: Add test CI for arm Runners #123

merged 1 commit into from
Sep 13, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Sep 13, 2024

Fix #107

We have some jobs that run on ARM self-hosted runners, we should also add those: https://github.com/apache/arrow/blob/main/.github/workflows/go.yml#L80-L91

@raulcd
Copy link
Member Author

raulcd commented Sep 13, 2024

@raulcd raulcd requested a review from kou September 13, 2024 10:06
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit eaf7703 into apache:main Sep 13, 2024
19 checks passed
@raulcd raulcd deleted the GH-107 branch September 13, 2024 12:21
@kou
Copy link
Member

kou commented Sep 13, 2024

Ah, we should have check ${GITHUB_REPOSITORY_OWNER} like https://github.com/apache/arrow/blob/62060ab55be2dc811e5abf0c5aba9834d3056ee1/.github/workflows/go.yml#L77-L93 to prevent running these jobs on forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test CI for arm Runners
2 participants