Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(arrow/cdata): handle export struct with no fields #175

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix(arrow/cdata): handle export struct with no fields #175

merged 2 commits into from
Oct 28, 2024

Conversation

zeroshade
Copy link
Member

Fixes #172

Includes a test that reproduced the original reported issue

@zeroshade
Copy link
Member Author

CC @ukclivecox

@ukclivecox
Copy link

ukclivecox commented Oct 25, 2024 •
edited
Loading

Thanks @zeroshade
Would the same not happen at line 430 for Union handling as well?

@zeroshade
Copy link
Member Author

@ukclivecox updated to account for union arrays too

kou
kou approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zeroshade zeroshade merged commit b7e68db into apache:main Oct 28, 2024
24 checks passed
@zeroshade zeroshade deleted the panic-zero-fields branch October 28, 2024 20:35
@ukclivecox ukclivecox mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

@joellubi joellubi Awaiting requested review from joellubi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on zero length array in exportArray
3 participants
@zeroshade @ukclivecox @kou