CI: Add gofmt check in lint

[singh1203]

Fixes: #58

What changes are included in this PR?

Added the gofmt check in the pre-commit-config.yml, which identifies files that need gofmt linting and make proper linting.

Are these changes tested?

Yes, I tested it on my forked repository example here

[zeroshade]

Would it make more sense to include this in the golangci configuration that we use with pre-commit instead? Particularly if we could have it so that pre-commit runs gofmt for the user too

[singh1203]

Would it make more sense to include this in the golangci configuration that we use with pre-commit instead? Particularly if we could have it so that pre-commit runs gofmt for the user too

Yes, you are correct. I raised the same question in yesterday's Arrow community meeting. I will incorporate the changes as per the review.

[singh1203]

Would it make more sense to include this in the golangci configuration that we use with pre-commit instead? Particularly if we could have it so that pre-commit runs gofmt for the user too

@zeroshade I made changes by adding a hook, which you can see here. This raises the question: do I need to commit the changed files after running pre-commit cmd locally?

[zeroshade]

@zeroshade I made changes by adding a hook, which you can see here. This raises the question: do I need to commit the changed files after running pre-commit cmd locally?

That's the way it would work, yes. I'm not sure if we'd want it to automatically commit the changed files.

[singh1203]

@zeroshade I made changes by adding a hook, which you can see here. This raises the question: do I need to commit the changed files after running pre-commit cmd locally?

That's the way it would work, yes. I'm not sure if we'd want it to automatically commit the changed files.

Yes you were right I need to commit, and also, instead of hook, I chose to go ahead with go fmt cmd since that pre-commit hook is no more being maintained. Aside from that, I think we can run the pre-commit run before pushing rather than autocommitting.
@kou Any thoughts for this?

[kou]

Can we use https://github.com/golangci/golangci-lint ?
It seems that it includes gofmt support: https://golangci-lint.run/usage/configuration/

We don't need to commit changes by pre-commit automatically. Developers should do it after they checked.