GH-601: [Gandiva] Synchronize some methods on the Projector #602
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
changed the title
|
@lriggs since you've been working on Gandiva lately, would you be able to help take a look at the changes here? |
kou
changed the title
kou
changed the title
|
We should rebase on main after we merge GH-595. |
Ok I'm clearly not paying attention...you are lriggs 😬 As Kou states, let's rebase this after the other PR. |
|
Could you rebase on main? |
lriggs
force-pushed
the
projectorSynch
branch
from
28cee4e to
9937099
Compare
This comment has been minimized.
This comment has been minimized.
lriggs
force-pushed
the
projectorSynch
branch
from
9937099 to
f852ce6
Compare
|
I rebased but don't seem to have permissions to add the bug-fix label. |
lidavidm
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Multiple threads can attempt to create the same llvm expression in Gandiva. This isn't allowed with the new JIT compiler, so synchronizing will prevent this scenario.
What changes are included in this PR?
Synchronize some methods to avoid adding duplicate llvm expressions.
Are these changes tested?
Yes, through unit tests in Gandiva.
Are there any user-facing changes?
No.
Closes GH-601