-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate public export of test_utils #7294
Comments
@alamb I can help to implement this, does this only need to add something like below in #[deprecated(
since = "54.3.2", <-- the current version is `54.3.1`, so use `54.3.2` here, can be changed if needed
note = "The `test_util` module is deprecated and will be removed in a future release."
)]
pub mod test_util; If this is the right way, I will file a pr for it, and if other things need to be done, please give some hints, and I'll adopt them. thanks. |
Thanks @klion26 ❤ Does this only need to add something like below in
Yes I think this is the right way. The since version should be |
I believe tests utils have a lot of value, I would love to have a crate for generating arrays and record batches for easy testing and benchmarking |
Perhaps you can comment on #7375 The reason this got brought up actually was actually some tests I think you may have added in DataFusion that used the test utils. I agree utilities for generating arrays are useful. I think the question is how much benefit we get from having them reused in a library (vs the maintenance cost) compared to, for example, just copying the relevant code where it is needed. I can see both points of view |
The
test_utils
package has a non trivial public API (e.g. it exposes rand) even though the code is fairly simpleIt would be nice to make this crate more self contained and thus I think we should deprecate and eventually remove
test_utils
from the public APIWhat do we think about merging this and marking all of bench_utils as deprecated (pointing out that external users should just copy the code into their repo if they want to use them) 🤔
Originally posted by @alamb in #7128 (comment)
The text was updated successfully, but these errors were encountered: