-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated the public expose of test_util package #7375
base: main
Are you sure you want to change the base?
Conversation
@alamb Please have a look at this when you're free, thanks. |
Thanks @klion26 -- this looks good though it looks like there are some clippy failures (as the code is still used internally). Is there any chance you can help fix the CI? |
@alamb Thanks for the review. I will take a look at the Clippy failures soon. |
@alamb Before making the change, could you please help to check something below, thanks.
|
I recommend doing the |
2f0fba3
to
996de3e
Compare
996de3e
to
df33710
Compare
There is some warnings for the test function in |
eff1233
to
4dd4071
Compare
4dd4071
to
8fff8b3
Compare
@@ -201,6 +201,7 @@ impl<T: Clone> Iterator for BadIterator<T> { | |||
} | |||
|
|||
#[cfg(test)] | |||
#[cfg(not(clippy))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this here because it will always throw the error after I try adding #[allow(deprecated)]
before mode tests
, use supper::*
, and the function name fn test_data_dir()
, fn test_happy()
.
@alamb, could you please look at this when you're free? thanks. |
Which issue does this PR close?
Closes #7294.
Rationale for this change
What changes are included in this PR?
Same as the issue
Are there any user-facing changes?
No