Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to run 64-bit tests on 32-bit platforms #6678

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

drauschenbach
Copy link

@drauschenbach drauschenbach commented Nov 4, 2024

Which issue does this PR close?

Closes #109.

I'm not qualified to enable arm32v7 in the CI environment, but this PR performs periodic maintenance to get all the tests to pass.

Rationale for this change

Tests should pass on the world's top 3 best-selling computers of all time. Also Arrow is great for edge computing, where hardware refresh cycles are considerably longer than in the datacenter.

What changes are included in this PR?

Tests that are specifically for 64-bit platforms are no longer attempted on 32-bit platforms.

Are there any user-facing changes?

Hopefully not. If so, I made a mistake.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 4, 2024
@github-actions github-actions bot removed the arrow Changes to the arrow crate label Nov 4, 2024
@drauschenbach drauschenbach marked this pull request as draft November 4, 2024 15:07
@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate parquet-derive labels Nov 4, 2024
@drauschenbach drauschenbach marked this pull request as ready for review November 4, 2024 18:29
@drauschenbach drauschenbach changed the title Perform CI checks for arm32v7 Don't attempt to run 64-bit tests on 32-bit platforms Nov 4, 2024
@drauschenbach drauschenbach marked this pull request as draft November 4, 2024 18:30
@drauschenbach drauschenbach marked this pull request as ready for review November 4, 2024 18:32
@drauschenbach
Copy link
Author

Testing on Raspberry Pi 4B

Running in armhf mode. The easy way to put it into that mode is by installing Raspbian 10.

$ cargo test
(all tests pass)

Environment

$ dpkg --print-architecture
armhf

$ cat /etc/os-release 
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

@tustvold
Copy link
Contributor

tustvold commented Nov 4, 2024

I think if we want to support 32-bit platforms we probably want to come up with a holistic plan first. As it stands we don't test against 32-bit architectures and so I likely lots of things won't work correctly.

I suspect there are probably people in the ecosystem interested in this, e.g. for WASM32, but I think we should ensure we're all on the same page and have a coherent plan of action, including for ongoing maintenance.

If this is something you want to drive forwards, perhaps you might file an issue to start the discussion? Unfortunately I have very limited capacity atm.

@drauschenbach
Copy link
Author

I think if we want to support 32-bit platforms we probably want to come up with a holistic plan first. As it stands we don't test against 32-bit architectures and so I likely lots of things won't work correctly.

I suspect there are probably people in the ecosystem interested in this, e.g. for WASM32, but I think we should ensure we're all on the same page and have a coherent plan of action, including for ongoing maintenance.

If this is something you want to drive forwards, perhaps you might file an issue to start the discussion? Unfortunately I have very limited capacity atm.

The comprehensive 32-bit support is already being tracked here: #262. This PR only attempts to close a bug about broken tests.

@tustvold
Copy link
Contributor

tustvold commented Nov 4, 2024

This PR only attempts to close a bug about broken tests

Right, but I'm pretty lukewarm about simply disabling failing tests, many are legitimate bugs. Not only could this mislead people about the current state of support, it would also likely complicate any potential future initiative to actually provide proper support for such architectures.

@drauschenbach
Copy link
Author

drauschenbach commented Nov 4, 2024

Right, but I'm pretty lukewarm about simply disabling failing tests, many are legitimate bugs. Not only could this mislead people about the current state of support, it would also likely complicate any potential future initiative to actually provide proper support for such architectures.

Thanks for the suggestion @tustvold. I've started the discussion here: #6681.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate parquet-derive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures on 32 bit ARM (Raspberry Pi)
2 participants