add try_new_with_length constructor to FixedSizeList
#8624
+141
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes existing tests and adds some more test cases for degenerate `FixedSizeList`s. Signed-off-by: Connor Tsui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8623
As a first step for fixing #8623, this PR introduces a
try_new_with_lengthconstructor forFixedSizeListArraythat takes in alenparameter for the specific case of non-nullable, degenerate arrays.To be honest, I think updating the existing constructors makes more sense (breaking change), but this is an easier first step because we can just make
try_new_with_lengththe newtry_newfrom here.I also fixed 2 cases of an existing unit test that were wrong, as well as added an extra test for the degenerate case.
Edit: I realized that the constructors also do not check if the list size correctly divides the input
values.len()intry_new, so added a check for that plus more tests.