Add cast support for (Large)ListView <-> (Large)List #8735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
vegarsti
commented
Oct 29, 2025
vegarsti
commented
Oct 29, 2025
vegarsti
commented
Oct 29, 2025
vegarsti
commented
Oct 29, 2025
vegarsti
force-pushed
the
cast-list-view
branch
2 times, most recently
from
3065079 to
36065f0
Compare
vegarsti
commented
Oct 29, 2025
vegarsti
force-pushed
the
cast-list-view
branch
from
36065f0 to
5701fce
Compare
vegarsti
commented
Oct 30, 2025
asubiotto
reviewed
Oct 30, 2025
|
cc @connortsui20 in case you want to take a look at this casting code in datafusion, since you've done a bunch of related things in vortex. |
vegarsti
force-pushed
the
cast-list-view
branch
from
5701fce to
71e0c6c
Compare
vegarsti
commented
Oct 30, 2025
| OffsetSize: OffsetSizeTrait, | ||
| { | ||
| let list = array.as_list::<OffsetSize>(); | ||
| let list_view: GenericListViewArray<OffsetSize> = list.clone().into(); |
There was a problem hiding this comment.
This uses a new From impl, because I saw that was the pattern for other types into ListViewArray, but we don't do that for ListView to List. Just pointing out the inconsistency, but think it's fine.
vegarsti
commented
Oct 31, 2025
Comment on lines
+160
to
+165
| (ListView(list_from), List(list_to)) => { | ||
| can_cast_types(list_from.data_type(), list_to.data_type()) | ||
| } | ||
| (LargeListView(list_from), LargeList(list_to)) => { | ||
| can_cast_types(list_from.data_type(), list_to.data_type()) | ||
| } |
There was a problem hiding this comment.
I forgot to simplify this branch, will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to tracking issue #5375 for
ListView.Rationale for this change
We need cast support for
ListViewandLargeListView.Are these changes tested?
Yes