-
Notifications
You must be signed in to change notification settings - Fork 1k
Updated arrow-pyarrow to use pyo3 0.27, updated deprecated code warnings #8773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hntd187
wants to merge
12
commits into
apache:main
Choose a base branch
from
hntd187:update-pyo3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # arrow-pyarrow/src/lib.rs
kylebarron
reviewed
Nov 3, 2025
kylebarron
approved these changes
Nov 3, 2025
mbrobbel
reviewed
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hntd187. Please note that this is a breaking change because we use pyo3 types in public items.
Co-authored-by: Matthijs Brobbel <[email protected]>
Co-authored-by: Matthijs Brobbel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-change
Changes to the arrow API
next-major-release
the PR has API changes and it waiting on the next major version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue, I'm aware of. Just updates pyo3 to 0.27 so delta-rs can start looking at variant adoption.
Rationale for this change
There is a long list of dependencies for arrow 57 to be supported in enough places such that delta-rs can start to reliably build against them. Updating pyo3 puts arrow in line with the other arrow based dependencies.
Are these changes tested?
We typically require tests for all PRs in order to:
Since this is a good amount of unsafe, and I'm on Windows (which I'd imagine is not the common path) I'd like to see the CI/CD run just to make sure everything looks good.
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
Just that a dependency is now a later version