Skip to content

Conversation

@hntd187
Copy link
Contributor

@hntd187 hntd187 commented Nov 3, 2025

Which issue does this PR close?

No issue, I'm aware of. Just updates pyo3 to 0.27 so delta-rs can start looking at variant adoption.

Rationale for this change

There is a long list of dependencies for arrow 57 to be supported in enough places such that delta-rs can start to reliably build against them. Updating pyo3 puts arrow in line with the other arrow based dependencies.

Are these changes tested?

We typically require tests for all PRs in order to:
Since this is a good amount of unsafe, and I'm on Windows (which I'd imagine is not the common path) I'd like to see the CI/CD run just to make sure everything looks good.

If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?

Are there any user-facing changes?

Just that a dependency is now a later version

@mbrobbel mbrobbel added api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version labels Nov 4, 2025
@mbrobbel mbrobbel added this to the 58.0.0 milestone Nov 4, 2025
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hntd187. Please note that this is a breaking change because we use pyo3 types in public items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants