-
Notifications
You must be signed in to change notification settings - Fork 1k
[Parquet] Avoid copying LogicalType in ColumnOrder::get_sort_order, deprecate get_logical_type
#8789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LogicalType in ColumnOrder::get_sort_order
|
If we deprecate the I agree this isn't an earth shaking performance enhancer 😄 But it might have a small effect on the metadata decoding. |
I can certainly do that |
…recate logical_type()
ac7ea02 to
3dacc15
Compare
LogicalType in ColumnOrder::get_sort_orderLogicalType in ColumnOrder::get_sort_order, deprecate get_logical_type
|
|
||
| impl ColumnOrder { | ||
| /// Returns sort order for a physical/logical type. | ||
| #[deprecated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is one deprecation
| /// | ||
| /// Note that this function will clone the `LogicalType`. If performance is a concern, | ||
| /// use [`Self::logical_type_ref`] instead. | ||
| #[deprecated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just straight up deprecated the non reference version
LogicalType in ColumnOrder::get_sort_order, deprecate get_logical_typeLogicalType in ColumnOrder::get_sort_order, deprecate get_logical_type
I deprecated it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alamb!
Co-authored-by: Ed Seidl <[email protected]>
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
Which issue does this PR close?
Rationale for this change
@etseidl suggested:
What changes are included in this PR?
ColumnOrder::get_sort_orderAre these changes tested?
Yes by CI
Note I was not able to observe any changes in benchmark performance with this, so I am not sure it it worth doing
Are there any user-facing changes?
There is a new API but I think there not many people use this (low level) API so the disruption should be minimal