Add VariantPath::is_empty
#8791
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
force-pushed
the
friendlymatthew/variant-path-is-empty
branch
from
bc00c60 to
8e2a0ca
Compare
friendlymatthew
force-pushed
the
friendlymatthew/variant-path-is-empty
branch
from
8e2a0ca to
ee62996
Compare
alamb
approved these changes
Nov 5, 2025
scovich
reviewed
Nov 5, 2025
There was a problem hiding this comment.
Seems fine, but shouldn't the existing impl Deref (L130 below) transparently provide access to slice.is_empty? (c.f. playground)
I think having an explicit method is probably still helpful even if it is strictly unecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR adds
VariantPath::is_emptywhich checks whetherVariantPathcontains an empty list ofVariantPathElements.I found this API to be helpful when validating a
VariantPath, since aVariantPathis only meaningful if it holds a nonempty list ofVariantPathElements