-
Notifications
You must be signed in to change notification settings - Fork 1k
Alamb/test boolean kernels #8793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…table. but I don't want to pass slice of bytes as then I don't know the source and users must make sure that they hold the same promises as Buffer/MutableBuffer
…olean-buffer-builder
…m:rluvaton/arrow-rs into add-bitwise-ops-to-boolean-buffer-builder
…olean-buffer-builder
f71a57e to
b0cf38b
Compare
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
That is interesting that OR is slower |
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
What changes are included in this PR?
apply_unary_opandapply_binary_opbitwise operations #8619 to the existing boolean kernelsbenchmark results for boolean_kernels
Are these changes tested?
will benchmark
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.