arrow-row: Add ListView support #9176
Conversation
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Hi, do you mind rebasing? I think CI is failing because this needs to be rebased on the latest master- the base branch is missing the encoded_len fn that was added recently
Otherwise, the implementation makes sense to me
brancz
force-pushed
the
row-list-view
branch
2 times, most recently
from
cd2a465 to
29f13ef
Compare
|
Very confused because both this PR and #9175 are based off of latest main, and the tip of the other PR seems to work fine. |
|
Figured it out, I did actually need to change something after the rebase here, also refactored the use in both list-types. |
| list_size += 1; | ||
| } | ||
| } | ||
| O::from_usize(child_count).expect("overflow"); |
There was a problem hiding this comment.
Is this to force a panic?
| .collect(); | ||
|
|
||
| let child = unsafe { converter.convert_raw(&mut child_rows, validate_utf8) }?; | ||
| assert_eq!(child.len(), 1); |
There was a problem hiding this comment.
Should we return an error here since the function returns a result anyway?
|
|
||
| /// Computes the minimum offset and maximum end (offset + size) for a ListView array. | ||
| /// Returns (min_offset, max_end) which can be used to slice the values array. | ||
| fn compute_list_view_bounds<O: OffsetSizeTrait>(array: &GenericListViewArray<O>) -> (usize, usize) { |
There was a problem hiding this comment.
This function seems oddly placed; should be lower down instead of in the middle of the mod declarations?
3 participants
Which issue does this PR close?
Closes #9174
What changes are included in this PR?
Implementation and tests. It's mostly copied from
List.Are these changes tested?
Yes, see unit tests.
Are there any user-facing changes?
No, purely additive.
@alamb @Jefffrey