GH-45800: [C++] Implement util configuration in Meson

[WillAyd]

Rationale for this change

This continues to add support for Meson in the Arrow C++ codebase

What changes are included in this PR?

The util directory has been added to the Meson configuration

Are these changes tested?

Yes

Are there any user-facing changes?

No

• GitHub Issue: [C++] Add util directory to Meson #45800

[github-actions]

⚠️ GitHub issue #45800 has been automatically assigned in GitHub to PR creator.

[github-actions]

⚠️ GitHub issue #45800 has no components, please add labels for components.

[WillAyd]

@github-actions crossbow submit *meson

[github-actions]

Revision: 67896cb

Submitted crossbow builds: ursacomputing/crossbow @ actions-b05af5f8a2

Task	Status
test-conda-cpp-meson

[WillAyd]

@github-actions crossbow submit *meson

[github-actions]

Revision: f5cebe7

Submitted crossbow builds: ursacomputing/crossbow @ actions-8cfff641da

Task	Status
test-conda-cpp-meson

[kou]

Suggested change

	if host_machine.system() == 'windows'
	# This manifest enables long file paths on Windows 10+
	# See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
	if cpp_compiler.get_id() == 'msvc'
	io_util_test_sources = ['io_util_test.cc', 'io_util_test.manifest']
	else
	io_util_test_sources = ['io_util_test.cc', 'io_util_test.rc']
	endif
	else
	io_util_test_sources = ['io_util_test.cc']
	endif
	io_util_test_sources = ['io_util_test.cc']
	if host_machine.system() == 'windows'
	# This manifest enables long file paths on Windows 10+
	# See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
	if cpp_compiler.get_id() == 'msvc'
	io_util_test_sources += ['io_util_test.manifest']
	else
	io_util_test_sources += ['io_util_test.rc']
	endif
	endif

Can we use the following?

utility_test_srcs = [
    ...,
    'io_util_test.cc'
    ...
]
if host_machine.system() == 'windows'
    # This manifest enables long file paths on Windows 10+
    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
    if cpp_compiler.get_id() == 'msvc'
        utility_test_srcs += ['io_util_test.manifest']
    else
        utility_test_srcs += ['io_util_test.rc']
    endif
endif

[WillAyd]

@github-actions crossbow submit *meson

[github-actions]

Revision: 3903125

Submitted crossbow builds: ursacomputing/crossbow @ actions-f5d42b5ad9

Task	Status
test-conda-cpp-meson

[WillAyd]

@github-actions crossbow submit *meson

[github-actions]

Revision: d1fcfed

Submitted crossbow builds: ursacomputing/crossbow @ actions-fbda2d1a9d

Task	Status
test-conda-cpp-meson

[kou]

Do we need this?

[WillAyd]

We do. I think there are ways to improve the terminology, but technically the arrow_test_dep becomes a disabler only if needs_testing is false. It is possible for needs_tests to be false while needs_testing is true. Without this extra condition these tests would build when -Dtests=false and -Dtesting=true

I do wonder if it wouldn't be better to have an arrow_test_dep and separately an arrow_testing_dep

[kou]

If we need this here, we need it for test('arrow-utility-test', exc) too?

It seems that we don't need both arrow_test_dep and arrow_testing_dep. Can we use this instead?

if needs_tests
    arrow_test_dep = declare_dependency(
        link_with: [arrow_test_lib],
        dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
    )
else
    arrow_test_dep = disabler()
endif

[WillAyd]

Nice catch on the arrow-utility-test - I can do that.

With respect to the if needs_tests, it depends how much we want to adhere to what CMake has in place. In fact, we used to use that same condition, but I had to change it from if needs_tests to if needs_testing in the benchmarks PR.

https://github.com/apache/arrow/pull/45793/files

Unless I am misreading the CMake configuration (which is certainly possible) it seems like it is possible to disable tests but turn the benchmarks on. In such a case, you would still need the current arrow_test_dep dependency to build benchmarks; the change you are proposing would add a dependency between the test suite and benchmark suite

[kou]

Can we use separated dependency for benchmarks something like the following?

if needs_tests
    arrow_test_dep = declare_dependency(
        link_with: [arrow_test_lib],
        dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
    )
else
    arrow_test_dep = disabler()
endif

if needs_benchmarks
  arrow_benchmark_dep = declare_dependency(
        dependencies: [benchmark_dep, arrow_test_dep],
    )
else
  arrow_benchmark_dep = disabler()
end

[WillAyd]

Yes we can. Nice idea!

[kou]

Do we need gtest_main_dep here?

[WillAyd]

arrow_test_dep already provides gtest_main_dep transitively

[kou]

Ah, arrow_test_dep doesn't link to only libarrow_testing.so.

Then can we remove filesystem_dep from arrow-crc32-test dependencies?

[WillAyd]

Ah nice catch - yea we can do that for now