GH-45800: [C++] Implement util configuration in Meson #45824

WillAyd · 2025-03-17T18:05:34Z

Rationale for this change

This continues to add support for Meson in the Arrow C++ codebase

What changes are included in this PR?

The util directory has been added to the Meson configuration

Are these changes tested?

Yes

Are there any user-facing changes?

No

GitHub Issue: [C++] Add util directory to Meson #45800

github-actions · 2025-03-17T18:06:02Z

⚠️ GitHub issue #45800 has been automatically assigned in GitHub to PR creator.

github-actions · 2025-03-17T18:06:03Z

⚠️ GitHub issue #45800 has no components, please add labels for components.

WillAyd · 2025-03-17T18:06:09Z

@github-actions crossbow submit *meson

github-actions · 2025-03-17T18:08:21Z

Revision: 67896cb

Submitted crossbow builds: ursacomputing/crossbow @ actions-b05af5f8a2

Task	Status
test-conda-cpp-meson

WillAyd · 2025-03-17T18:56:59Z

@github-actions crossbow submit *meson

github-actions · 2025-03-17T18:59:14Z

Revision: f5cebe7

Submitted crossbow builds: ursacomputing/crossbow @ actions-8cfff641da

Task	Status
test-conda-cpp-meson

kou · 2025-03-18T03:56:28Z

cpp/src/arrow/util/meson.build

+if host_machine.system() == 'windows'
+    # This manifest enables long file paths on Windows 10+
+    # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later
+    if cpp_compiler.get_id() == 'msvc'
+        io_util_test_sources = ['io_util_test.cc', 'io_util_test.manifest']
+    else
+        io_util_test_sources = ['io_util_test.cc', 'io_util_test.rc']
+    endif
+else
+    io_util_test_sources = ['io_util_test.cc']
+endif


Suggested change

if host_machine.system() == 'windows'

# This manifest enables long file paths on Windows 10+

# See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later

if cpp_compiler.get_id() == 'msvc'

io_util_test_sources = ['io_util_test.cc', 'io_util_test.manifest']

else

io_util_test_sources = ['io_util_test.cc', 'io_util_test.rc']

endif

else

io_util_test_sources = ['io_util_test.cc']

endif

io_util_test_sources = ['io_util_test.cc']

if host_machine.system() == 'windows'

# This manifest enables long file paths on Windows 10+

# See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later

if cpp_compiler.get_id() == 'msvc'

io_util_test_sources += ['io_util_test.manifest']

else

io_util_test_sources += ['io_util_test.rc']

endif

endif

Can we use the following?

utility_test_srcs = [ ..., 'io_util_test.cc' ... ] if host_machine.system() == 'windows' # This manifest enables long file paths on Windows 10+ # See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#enable-long-paths-in-windows-10-version-1607-and-later if cpp_compiler.get_id() == 'msvc' utility_test_srcs += ['io_util_test.manifest'] else utility_test_srcs += ['io_util_test.rc'] endif endif

WillAyd · 2025-03-18T04:03:19Z

@github-actions crossbow submit *meson

github-actions · 2025-03-18T04:05:30Z

Revision: 3903125

Submitted crossbow builds: ursacomputing/crossbow @ actions-f5d42b5ad9

Task	Status
test-conda-cpp-meson

WillAyd · 2025-03-18T15:12:43Z

@github-actions crossbow submit *meson

github-actions · 2025-03-18T15:14:57Z

Revision: d1fcfed

Submitted crossbow builds: ursacomputing/crossbow @ actions-fbda2d1a9d

Task	Status
test-conda-cpp-meson

kou · 2025-03-19T03:08:19Z

cpp/src/arrow/util/meson.build

+    },
+}
+
+if needs_tests


Do we need this?

We do. I think there are ways to improve the terminology, but technically the arrow_test_dep becomes a disabler only if needs_testing is false. It is possible for needs_tests to be false while needs_testing is true. Without this extra condition these tests would build when -Dtests=false and -Dtesting=true

I do wonder if it wouldn't be better to have an arrow_test_dep and separately an arrow_testing_dep

If we need this here, we need it for test('arrow-utility-test', exc) too?

It seems that we don't need both arrow_test_dep and arrow_testing_dep. Can we use this instead?

if needs_tests arrow_test_dep = declare_dependency( link_with: [arrow_test_lib], dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep], ) else arrow_test_dep = disabler() endif

Nice catch on the arrow-utility-test - I can do that.

With respect to the if needs_tests, it depends how much we want to adhere to what CMake has in place. In fact, we used to use that same condition, but I had to change it from if needs_tests to if needs_testing in the benchmarks PR.

https://github.com/apache/arrow/pull/45793/files

Unless I am misreading the CMake configuration (which is certainly possible) it seems like it is possible to disable tests but turn the benchmarks on. In such a case, you would still need the current arrow_test_dep dependency to build benchmarks; the change you are proposing would add a dependency between the test suite and benchmark suite

Can we use separated dependency for benchmarks something like the following?

if needs_tests arrow_test_dep = declare_dependency( link_with: [arrow_test_lib], dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep], ) else arrow_test_dep = disabler() endif if needs_benchmarks arrow_benchmark_dep = declare_dependency( dependencies: [benchmark_dep, arrow_test_dep], ) else arrow_benchmark_dep = disabler() end

Yes we can. Nice idea!

kou · 2025-03-19T03:09:05Z

cpp/src/arrow/util/meson.build

+        exc = executable(
+            key,
+            sources: val['sources'],
+            dependencies: [arrow_test_dep, val.get('dependencies', [])],


Do we need gtest_main_dep here?

arrow_test_dep already provides gtest_main_dep transitively

Ah, arrow_test_dep doesn't link to only libarrow_testing.so.

Then can we remove filesystem_dep from arrow-crc32-test dependencies?

Ah nice catch - yea we can do that for now

WillAyd · 2025-04-09T20:41:19Z

@github-actions crossbow submit *meson

github-actions · 2025-04-09T20:43:34Z

Revision: cc1cb9c

Submitted crossbow builds: ursacomputing/crossbow @ actions-16f3047112

Task	Status
test-conda-cpp-meson

kou

+1

conbench-apache-arrow · 2025-04-10T06:52:11Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9d9e9a5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

…5824) ### Rationale for this change This continues to add support for Meson in the Arrow C++ codebase ### What changes are included in this PR? The util directory has been added to the Meson configuration ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#45800 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

github-actions bot added the Component: C++ label Mar 17, 2025

github-actions bot added the awaiting review Awaiting review label Mar 17, 2025

kou reviewed Mar 18, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Mar 18, 2025

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 18, 2025

WillAyd force-pushed the meson-implement-util branch from 3903125 to d1fcfed Compare March 18, 2025 15:12

kou reviewed Mar 19, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Mar 19, 2025

WillAyd mentioned this pull request Mar 20, 2025

[C++] Create dedicated benchmark dependency in Meson Configuration #45865

Closed

WillAyd added 3 commits April 9, 2025 15:29

apacheGH-45800: [C++] Implement util configuration in Meson

18b205a

Fix installation directories for headers

7850b6b

kou feedback

cc1cb9c

WillAyd force-pushed the meson-implement-util branch from d1fcfed to cc1cb9c Compare April 9, 2025 20:33

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 9, 2025

kou approved these changes Apr 10, 2025

View reviewed changes

kou merged commit 9d9e9a5 into apache:main Apr 10, 2025
35 of 37 checks passed

kou removed the awaiting change review Awaiting change review label Apr 10, 2025

github-actions bot added the awaiting merge Awaiting merge label Apr 10, 2025

kou mentioned this pull request Apr 10, 2025

[C++] Add util directory to Meson #45800

Closed

GH-45800: [C++] Implement util configuration in Meson #45824

GH-45800: [C++] Implement util configuration in Meson #45824

Uh oh!

Conversation

WillAyd commented Mar 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

WillAyd commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

WillAyd commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WillAyd commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

WillAyd commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WillAyd commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Apr 10, 2025

Uh oh!

Uh oh!

WillAyd commented Mar 17, 2025 •

edited by github-actions bot

Loading