GH-45819: [C++] Add OptionalBitmapAnd utility function #45869
+124
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions crossbow submit -g cpp |
|
Revision: 4188841 Submitted crossbow builds: ursacomputing/crossbow @ actions-fd8ca4245c
|
|
CI failures are unrelated. Happy to rebase once they are fixed. @pitrou is something like this what you had in mind? |
pitrou
reviewed
Mar 20, 2025
| /// their respective bit-offsets for the given bit-length and put | ||
| /// the results in out_buffer starting at the given bit-offset. | ||
| /// Both right and left buffers are optional. If any of the buffers is | ||
| /// null a bitmap of zeros is returned. |
There was a problem hiding this comment.
Hmm, actually, the more useful semantics is that a null pointer means the bitmap is all-1s.
This reflects the situation where an Array doesn't have a null bitmap: all values are valid.
There was a problem hiding this comment.
And this would be even more useful as:
Result<std::shared_ptr<Buffer>> OptionalBitmapAnd(
MemoryPool* pool, const std::shared_ptr<Buffer>& left, int64_t left_offset,
const std::shared_ptr<Buffer>& right, int64_t right_offset, int64_t out_offset);... because then, if one of the inputs is null, and the offsets are compatible, we can return the other input (perhaps sliced) instead of allocating a new buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bitmaps are optional, having the possibility an utility function that allows us to do a
BitmapAndoperation that takes into account the possibility of a bitmap being null can be handy as we don't have to cater for the specific case.What changes are included in this PR?
Add a new
OptionalBitmapAndfunction.Are these changes tested?
Yes.
Are there any user-facing changes?
No, just a new utility function.
OptionalBitmapAndutility #45819