-
Notifications
You must be signed in to change notification settings - Fork 3.7k
MINOR: [Dev] Add yum build directories to .gitignore
#46018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@kou Should other directories be added here? |
@@ -18,3 +18,6 @@ | |||
# Python virtual environments for dev tools | |||
.venv*/ | |||
|
|||
# yum-based builds copy a lot of files there | |||
tasks/linux-packages/apache-arrow/yum/build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. This directory isn't created by default.
Did you use BUILD_DIR=build
?
build_dir = ENV["BUILD_DIR"] |
BTW, we have .gitignore
for dev/tasks/linux-packages/
: https://github.com/apache/arrow/blob/main/dev/tasks/linux-packages/.gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. This directory isn't created by default.
Did you useBUILD_DIR=build
?
No, I didn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you copy & paste this?
rake --trace {{ task_namespace }}:build BUILD_DIR=build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I probably did at the some point, since I was trying to reproduce those builds :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Can we close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, isn't it common to do just what I did? It would still sound useful to have a gitignore pattern for that, we already have other convenience patterns, see
https://github.com/apache/arrow/blob/main/.gitignore and https://github.com/apache/arrow/blob/main/cpp/ for examples (text editor files, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it for ccache in CI.
If we want to add it, could you do it in dev/tasks/linux-packages/.gitignore
that already has entries for dev/tasks/linux-packages/
?
diff --git a/dev/tasks/linux-packages/.gitignore b/dev/tasks/linux-packages/.gitignore
index 0e49a90c1e..138662a4ef 100644
--- a/dev/tasks/linux-packages/.gitignore
+++ b/dev/tasks/linux-packages/.gitignore
@@ -16,13 +16,15 @@
# under the License.
/*/*.tar.gz
-/*/apt/repositories/
-/*/apt/tmp/
/*/apt/build.sh
+/*/apt/build/
/*/apt/env.sh
-/*/yum/repositories/
-/*/yum/tmp/
+/*/apt/repositories/
+/*/apt/tmp/
/*/yum/build.sh
+/*/yum/build/
/*/yum/env.sh
+/*/yum/repositories/
+/*/yum/tmp/
/apt/repositories/
Rationale for this change
yum-based packaging builds copy/create a lot of files that weren't marked as ignored, so they were not deleted by
git clean -Xfd
.Are these changes tested?
Manually.
Are there any user-facing changes?
No.