Skip to content

MINOR: [Dev] Add apt/yum build directories to .gitignore #46018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 3, 2025

Rationale for this change

Linux packaging builds copy/create a lot of files that weren't marked as ignored, so they were not deleted by git clean -Xfd.

Are these changes tested?

Manually.

Are there any user-facing changes?

No.

@pitrou
Copy link
Member Author

pitrou commented Apr 3, 2025

@kou Should other directories be added here?

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 3, 2025
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 3, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 23, 2025
@pitrou pitrou changed the title MINOR: [Dev] Add yum build directories to .gitignore MINOR: [Dev] Add apt/yum build directories to .gitignore Apr 23, 2025
@pitrou pitrou merged commit 520ae44 into apache:main Apr 23, 2025
7 of 8 checks passed
@pitrou pitrou removed the awaiting change review Awaiting change review label Apr 23, 2025
@pitrou pitrou deleted the minor-gitignore branch April 23, 2025 15:13
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 520ae44.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 82 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants