WIP: Dummy PR to check maint-20.0.0 status #46037
Draft
+656
−674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ### Rationale for this change See: #46023 ### What changes are included in this PR? 1. Bumped `mathworks/libmexclass` version to git commit `2a75a5e9bbb524a044572598e371c994cc715d3d`. This version of `mathworks/libmexclass` requires CMake version `3.6.0` or later, which is compatible with CMake 4.0.0 (used by `apache/arrow`. ### Are these changes tested? Yes. 1. [Pending MATLAB CI job running in `mathworks/arrow`]( https://github.com/mathworks/arrow/actions/runs/14269264384). ### Are there any user-facing changes? Yes. 1. Users will now need CMake version `3.6.0` or later to build the MATLAB interface. ### Notes 1. Thank you @ sgilmore10 for your help with this pull request! * GitHub Issue: #46023 Authored-by: Kevin Gurney <[email protected]> Signed-off-by: Kevin Gurney <[email protected]>
### Rationale for this change reticulate may create some files in home directory. It's not desired on CRAN. ### What changes are included in this PR? Disable tests that use reticulate. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #45714 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This gets rid of `OBJECT`, `DATAPTR` has been replaced with `INTEGER()`, `REAL()`, etc. though strings are more complicated. I will fully admit that this C++ is stretching my comfort zone, so might include obviously wrong things! CI is currently failing, but I'm not totally sure yet if that means the code changes here are wrong or if maybe these allow us to have slightly different assumptions about materialization (see #45951 (comment)) I've also requested reviews broadly for folks I know have been around this code before, I appreciate any effort that y'all can spare 🙏 * GitHub Issue: #45949 Lead-authored-by: Jonathan Keane <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>
### Rationale for this change We need explicit upcast for `std::unique_ptr<>` with g++ 7.5.0. ### What changes are included in this PR? Add explicit upcast. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #46022 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change We always use `BoostConfig.cmake` by #45623. We don't use `FindBoost.cmake`. We need to use recent vcpkg to use `BoostConfig.cmake` because old Boost doesn't provide it. ### What changes are included in this PR? * Update `vcpkg.json` for `cpp/` and `c_glib/`. * Always use the latest vcpkg instead of using vcpkg bundled in Visual Studio. * C++: Don't use gflags for building bundled gRPC because bundled gRPC doens't use gflags. * C++: Don't define `-D*_EXPORT` macros to `Cflags.private` in `*.pc` because pkgconf 1.7.4 or later uses `--static` by default on Windows. If `--static` is used by default, `*_EXPORT`s are defined for shared linking. It causes link errors. This is a workaround of this. * FYI: pkgconf/pkgconf@008d706 * GLib: Add support for finding Apache Arrow C++ by CMake. It's another workaround for the pkgconf problem. If we use CMake, the pkgconf problem isn't related. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #45994 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
github-actions
bot
added
Component: R
Component: C++
Component: FlightRPC
Component: Gandiva
Component: GLib
Component: MATLAB
awaiting review
|
@github-actions crossbow submit --group verify-rc-source --group packaging |
|
Revision: caf885b Submitted crossbow builds: ursacomputing/crossbow @ actions-7ed1a76d04
|
…alled on free-threaded Windows wheel tests (#46042) ### Rationale for this change Pandas is currently not providing nightly wheels for free-threaded wheels. It has been failing for a while on their nightly channels and built wheels have been removed. Building from source fails on our free-threaded job. In order to provide our pyarrow Windows free-threaded wheels for 20.0.0 we temporarily disable installing pandas and testing pandas on free-threaded. ### What changes are included in this PR? Temporarily disable pandas from being installed and tested on the Windows free-threaded wheel. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: #46041 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
### Rationale for this change Prevent warnings on CRAN ### What changes are included in this PR? Remove paths on windows analogous to linux. ### Are these changes tested? Yes, via winbuilder ### Are there any user-facing changes? No * GitHub Issue: #46050 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
### Rationale for this change Keep NEWS.md in sync ### What changes are included in this PR? Update NEWS.md ### Are these changes tested? No ### Are there any user-facing changes? No * GitHub Issue: #46051 Lead-authored-by: "Bryce Mecum <[email protected]>" Co-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit e0708c7. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
@github-actions crossbow submit --group packaging |
|
I am just triggering the above because some new nightly failures seem they might fail here too :( Just trying to validate |
|
Revision: e0708c7 Submitted crossbow builds: ursacomputing/crossbow @ actions-6bb0a86962
|
|
It seems it was either a hiccup or not happening here from the CI jobs! That's great! 👍 |
|
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit e0708c7. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. |
### Rationale for this change A Yum repository uses hash value for metadata file name. e.g.: https://apache.jfrog.io/artifactory/arrow/almalinux/9/x86_64/repodata/00965b628ce7491674b8b0e20355e2c0e81c8d57b04b7e88ac2e6777aad09472-filelists.sqlite.bz2 We can remove old metadata files when update a Yum repository's metadata. But our Artifactory/Maven repository client implementation (`dev/release/binary-task.rb`) doesn't have a complete implementation for removing existing files. But our configuration enables the feature. ### What changes are included in this PR? Disable the feature. The feature was enabled by #45903 accidentally. Old implementation disables the feature. So this doesn't change the existing behavior. (Garbage will be increased in Yum repositories...) ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46072 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Flatbuffers statically requires that the version used to generate the prototypes within the code base is the same version used to compile it. A system install of Flatbuffers is therefore highly unlikely to be usable ### What changes are included in this PR? Removed the system install of Flatbuffers on macOS ### Are these changes tested? In CI ### Are there any user-facing changes? No * GitHub Issue: #46067 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…Maven repository (#46082) ### Rationale for this change `uploaded-files.txt` is for Artifactory. Artifactory doesn't have the staging feature. So we emulate the feature by `uploaded-files.txt`. But Maven repository has the feature. So we don't need to generate `uploaded-files.txt`. ### What changes are included in this PR? Don't generate `uploaded-files.txt`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46081 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Boost has remove their `include/boost/process/v1.hpp` ### What changes are included in this PR? Instead of using their old include file (which was a wrapper for the different includes) add the individual includes. ### Are these changes tested? Via CI. ### Are there any user-facing changes? No * GitHub Issue: #46111 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…s again (#46108) ### Rationale for this change It seems that ASF's Maven repository (Nexus 2) isn't suitable for APT/Yum repositories because it can't update existing files. We need to update existing files for APT/Yum repositories' metadata. Let's keep using Artifactory for 20.0.0. We may revisit this after 20.0.0 release. ### What changes are included in this PR? * Use Artifatory again. * Use packages.apache.org not apache.jfrog.io. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. (Keep the existing URL.) * GitHub Issue: #46083 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…w` on protobuf methods to `std::string` (#46136) ### Rationale for this change Protobuf v30.2 uses `absl::string_view` instead of `const char*` as seen here: protocolbuffers/protobuf@a9ad51f This is breaking on our CI. ### What changes are included in this PR? Explicitly convert `google::protobuf::EnumValueDescriptor::name()` and `google::protobuf::Message::descriptor()->full_name()` from `absl::string_view` to `std::string` ### Are these changes tested? Via CI, MinGW CI jobs use protobuf v30.2 and those are fixed with this change. ### Are there any user-facing changes? No * GitHub Issue: #46134 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.) **This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.) * GitHub Issue: #46075 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.