Skip to content

GH-46075: [Release][CI] Fix binary verification #46076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 15, 2025

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Apr 9, 2025

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

Copy link

github-actions bot commented Apr 9, 2025

⚠️ GitHub issue #46075 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 9, 2025
version=${package_id#apache-arrow-}
rc=${GITHUB_REF_NAME#*-rc}
rc=${RC_TAG#*-rc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about creating a job that detects target information something like the following?

diff --git a/.github/workflows/verify_rc.yml b/.github/workflows/verify_rc.yml
index fe46ae6f23..cc1eb6e6bf 100644
--- a/.github/workflows/verify_rc.yml
+++ b/.github/workflows/verify_rc.yml
@@ -30,7 +30,37 @@ env:
   VERBOSE: "1"
 
 jobs:
+  target:
+    runs-on: ubuntu-latest
+    timeout: 5
+    outputs:
+      package_id: ${{ steps.detect.outputs.package_id }}
+      version: ${{ steps.detect.outputs.version }}
+      rc: ${{ steps.detect.outputs.rc }}
+    steps:
+      - name: Detect
+        id: detect
+        run: |
+          case "${GITHUB_EVENT_NAME}" in
+            workflow_dispatch)
+              tag="${{ input.rc_tag }}"
+              ;;
+            pull_request)
+              tag="$(detect the latest RC tag)"
+              ;;
+            *)
+              tag="${GITHUB_REF_NAME}"
+              ;;
+          esac
+          package_id=${tag%-rc*}
+          version=${package_id#apache-arrow-}
+          rc=${tag#*-rc}
+          echo "package_id=${package_id}" >> "${GITHUB_OUTPUT}"
+          echo "version=${version}" >> "${GITHUB_OUTPUT}"
+          echo "rc=${rc}" >> "${GITHUB_OUTPUT}"
+
   apt:
+    needs: target
     name: APT
     runs-on: ${{ matrix.runs-on }}
     timeout-minutes: 30
@@ -41,15 +71,15 @@ jobs:
           - ubuntu-latest
           - ubuntu-24.04-arm
     env:
+      PACKAGE_ID: ${{ needs.target.outputs.package_id }}
+      RC: ${{ needs.target.outputs.rc }}
       TEST_APT: "1"
+      VERSION: ${{ needs.target.outputs.version }}
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - name: Run
         run: |
-          package_id=${GITHUB_REF_NAME%-rc*}
-          version=${package_id#apache-arrow-}
-          rc=${GITHUB_REF_NAME#*-rc}
-          dev/release/verify-release-candidate.sh ${version} ${rc}
+          dev/release/verify-release-candidate.sh ${VERSION} ${RC}
 
   binary:
     name: Binary

@assignUser assignUser marked this pull request as ready for review April 15, 2025 13:56
@assignUser assignUser merged commit 4937cf5 into apache:main Apr 15, 2025
13 of 17 checks passed
@assignUser assignUser removed the awaiting change review Awaiting change review label Apr 15, 2025
assignUser added a commit that referenced this pull request Apr 15, 2025
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

* GitHub Issue: #46075

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants