Skip to content

GH-46309: [C++] Clean up ignored-qualifiers warnings #46312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −16
Open

GH-46309: [C++] Clean up ignored-qualifiers warnings #46312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/cmake_modules/SetupCxxFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-conversion")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-sign-conversion")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wdate-time")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wignored-qualifiers")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wimplicit-fallthrough")
string(APPEND CXX_ONLY_FLAGS " -Wredundant-move")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wunused-result")
Expand Down
32 changes: 16 additions & 16 deletions cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ struct Year {

template <typename T, typename Arg0>
T Call(KernelContext*, Arg0 arg, Status*) const {
return static_cast<T>(static_cast<const int32_t>(
return static_cast<T>(static_cast<int32_t>(
year_month_day(floor<days>(localizer_.template ConvertTimePoint<Duration>(arg)))
.year()));
}
Expand All @@ -211,7 +211,7 @@ struct IsLeapYear {

template <typename T, typename Arg0>
T Call(KernelContext*, Arg0 arg, Status*) const {
int32_t y = static_cast<const int32_t>(
int32_t y = static_cast<int32_t>(
year_month_day(floor<days>(localizer_.template ConvertTimePoint<Duration>(arg)))
.year());
return y % 4 == 0 && (y % 100 != 0 || y % 400 == 0);
Expand All @@ -230,7 +230,7 @@ struct Month {

template <typename T, typename Arg0>
T Call(KernelContext*, Arg0 arg, Status*) const {
return static_cast<T>(static_cast<const uint32_t>(
return static_cast<T>(static_cast<uint32_t>(
year_month_day(floor<days>(localizer_.template ConvertTimePoint<Duration>(arg)))
.month()));
}
Expand All @@ -248,7 +248,7 @@ struct Day {

template <typename T, typename Arg0>
T Call(KernelContext*, Arg0 arg, Status*) const {
return static_cast<T>(static_cast<const uint32_t>(
return static_cast<T>(static_cast<uint32_t>(
year_month_day(floor<days>(localizer_.template ConvertTimePoint<Duration>(arg)))
.day()));
}
Expand All @@ -264,9 +264,9 @@ std::array<int64_t, 3> GetYearMonthDay(int64_t arg, Localizer&& localizer) {
const auto t = floor<days>(localizer.template ConvertTimePoint<Duration>(arg));
const auto ymd = year_month_day(t);

return {static_cast<int64_t>(static_cast<const int32_t>(ymd.year())),
static_cast<int64_t>(static_cast<const uint32_t>(ymd.month())),
static_cast<int64_t>(static_cast<const uint32_t>(ymd.day()))};
return {static_cast<int64_t>(static_cast<int32_t>(ymd.year())),
static_cast<int64_t>(static_cast<uint32_t>(ymd.month())),
static_cast<int64_t>(static_cast<uint32_t>(ymd.day()))};
}

template <typename Duration, typename InType>
Expand Down Expand Up @@ -298,9 +298,9 @@ struct YearMonthDayVisitValueFunction {
StructBuilder* struct_builder) {
return [=](typename InType::c_type arg) {
const auto ymd = GetYearMonthDay<Duration>(arg, NonZonedLocalizer{});
field_builders[0]->UnsafeAppend(static_cast<const int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<const uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<const uint32_t>(ymd[2]));
field_builders[0]->UnsafeAppend(static_cast<int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<uint32_t>(ymd[2]));
return struct_builder->Append();
};
}
Expand All @@ -315,18 +315,18 @@ struct YearMonthDayVisitValueFunction<Duration, TimestampType, BuilderType> {
if (timezone.empty()) {
return [=](TimestampType::c_type arg) {
const auto ymd = GetYearMonthDay<Duration>(arg, NonZonedLocalizer{});
field_builders[0]->UnsafeAppend(static_cast<const int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<const uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<const uint32_t>(ymd[2]));
field_builders[0]->UnsafeAppend(static_cast<int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<uint32_t>(ymd[2]));
return struct_builder->Append();
};
}
ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
return [=](TimestampType::c_type arg) {
const auto ymd = GetYearMonthDay<Duration>(arg, ZonedLocalizer{tz});
field_builders[0]->UnsafeAppend(static_cast<const int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<const uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<const uint32_t>(ymd[2]));
field_builders[0]->UnsafeAppend(static_cast<int32_t>(ymd[0]));
field_builders[1]->UnsafeAppend(static_cast<uint32_t>(ymd[1]));
field_builders[2]->UnsafeAppend(static_cast<uint32_t>(ymd[2]));
return struct_builder->Append();
};
}
Expand Down
Loading