-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46403: [C++] Add support for limiting element size when printing data #46536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
794440a
GH-46403: [C++] Add support for limiting element size when printing a…
david1437 568d6fc
fix: Change format when elements are truncated and add additional tests
david1437 64d3d5b
Use string_view::substr and fix python tests
david1437 3fc18de
fix lorem test
david1437 943d221
fix lorem test
david1437 18a0b94
fix lorem test
david1437 d3f6feb
fix lorem test
david1437 2d6d564
fix python test failure
david1437 43ae53d
fix add python bindings and test
david1437 354b1f8
rename python binding to match c++ field name
david1437 e070ce9
review corrections
david1437 641ae95
Improve tests + nits
pitrou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1357,7 +1357,8 @@ cdef class Array(_PandasConvertible): | |
return f'{type_format}\n{self}' | ||
|
||
def to_string(self, *, int indent=2, int top_level_indent=0, int window=10, | ||
int container_window=2, c_bool skip_new_lines=False): | ||
int container_window=2, c_bool skip_new_lines=False, | ||
int element_size_limit=100): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you perhaps add a unit test for passing a specific element_size_limit? |
||
""" | ||
Render a "pretty-printed" string representation of the Array. | ||
|
||
|
@@ -1383,6 +1384,8 @@ cdef class Array(_PandasConvertible): | |
skip_new_lines : bool | ||
If the array should be rendered as a single line of text | ||
or if each element should be on its own line. | ||
element_size_limit : int, default 100 | ||
Maximum number of characters of a single element before it is truncated. | ||
""" | ||
cdef: | ||
c_string result | ||
|
@@ -1392,6 +1395,7 @@ cdef class Array(_PandasConvertible): | |
options = PrettyPrintOptions(top_level_indent, window) | ||
options.skip_new_lines = skip_new_lines | ||
options.indent_size = indent | ||
options.element_size_limit = element_size_limit | ||
check_status( | ||
PrettyPrint( | ||
deref(self.ap), | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.