GH-46562: [GLib][CI] Enable ARROW_GLIB_WERROR by default#46563
Draft
hiroyuki-sato wants to merge 6 commits intoapache:mainfrom
Draft
GH-46562: [GLib][CI] Enable ARROW_GLIB_WERROR by default#46563hiroyuki-sato wants to merge 6 commits intoapache:mainfrom
hiroyuki-sato wants to merge 6 commits intoapache:mainfrom
Conversation
|
|
Collaborator
Author
|
Oh, It seems that we need to fix many warnings before this flag change. Change to draft. |
Collaborator
Author
|
https://github.com/apache/arrow/actions/runs/15199666662/job/42751369386?pr=46563 |
7e324b7 to
8420764
Compare
Collaborator
Author
|
We need to modify newline string on the Windows Platform. arrow/c_glib/arrow-glib/meson.build Lines 181 to 196 in 153da30 |
1eca642 to
305732e
Compare
305732e to
43eb26d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In GLib buiding, disabled
-Werrorcompiler flag by default.What changes are included in this PR?
Change
-Werrorby default. This change makes debugging easier.Are these changes tested?
Yes.
Are there any user-facing changes?
No.