Refactor: move type singleton logic into type.cc/h and tests#46616
Open
viky-01 wants to merge 1 commit intoapache:mainfrom
Open
Refactor: move type singleton logic into type.cc/h and tests#46616viky-01 wants to merge 1 commit intoapache:mainfrom
viky-01 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR addresses the feedback provided in issue [ #46531 ] (#46531), refactoring the singleton logic to follow the project's file organization conventions.
What changes are included in this PR?
Moved the singleton declaration to type.h
Moved the singleton definition to type.cc
Moved the corresponding test to type_test.cc
Are these changes tested?
✅ Yes, tests are included in type_test.cc.
Are there any user-facing changes?
❌ No, there are no user-facing or breaking changes in this PR.